Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 140
    • Merge requests 140
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !30437

Externals Update and AthGeneration Project Creation, master branch (2020.02.19.)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Attila Krasznahorkay requested to merge akraszna/athena:AthGeneration-master-20200217 into master Feb 17, 2020
  • Overview 32
  • Commits 5
  • Pipelines 1
  • Changes 49

The MR updates all projects to atlasexternals-2.0.57. The list of changes are (atlasexternals@2.0.56...2.0.57):

  • atlas_add_test(...) now always runs the post-processing script (if one is defined), even if the test executable failed (thanks to @fwinkl);
  • Updates to CheckerGccPlugins (thanks to @ssnyder);
  • atlas_generate_cliddb(...) no longer generates/uses a dummy_clid.db file (thanks to @fwinkl);
  • atlas_project(...) now only calls FindDoxygen.cmake if absolutely necessary (thanks to @fwinkl);
  • Fixed the patching of Acts when building the project with Clang (thanks to @ssnyder);
  • Added pyAMI to the list of modules built by the PyModules package (thanks to @fwinkl);
  • Added the AthGenerationExternals project to the master branch;
    • Updated the build configurations of FastJet(Contrib) and HepMCAnalysis to accommodate the "new" project.

For the last update (atlasexternals!612 (merged)) I had to make some changes in this MR as well, to start off the AthGeneration developments in the master branch.

Unfortunately a lot of code updates that were made in 21.6 are not available in master yet. I updated the xAODJet package to behave as it should (while also cleaning the code a bit), but once I realised how much work is necessary for MCTruthClassifier, I decided to give up. 😦 At this setup the build of AthGeneration at least "starts up". But then runs into a number of compilation issues.

But those I would prefer to leave to PMG to sort out. In future MRs. Possibly after an AthGeneration-master-x86_64-centos7-gcc8-opt nightly was already set up. (@aundrus, you'll probably get a request for this soon...)

Tagging @averbyts and @ewelina on this. In the end I decided that it will be easiest if we just merge this MR. Should make it easier for you guys to build on top of this.

Edited Feb 19, 2020 by Attila Krasznahorkay
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: AthGeneration-master-20200217