Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 140
    • Merge requests 140
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30442

WIP: Improved python3 compatibility and applied flake8 fixes.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Goetz Gaycken requested to merge goetz/athena:InDetAlignExample_master_Py3 into master Feb 17, 2020
  • Overview 6
  • Commits 1
  • Changes 28

For python3 compatibility replaced:

  • print by print function from future or by python logger to improve python3 compatibility,
  • except [class], [var]: by except [class] as [var]:,
  • raise [class],[msg] by raise class,
  • octal mumbers e.g. 0755 by 0o755,
  • commands.getstatusoutput by subprocess based solution.

To fix flake8 warnings, replaced

  • membership test: not [val] in [dict] by [val] not in [dict],
  • ==None by is None and !=None by not is None,
  • renamed ambiguous variables.
Edited Jan 07, 2021 by Goetz Gaycken
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: InDetAlignExample_master_Py3