Skip to content

CrestApi CMake Cleanup, master branch (2020.02.25.)

Attila Krasznahorkay requested to merge akraszna/athena:CrestCMakeFix-master-20200225 into master

While trying to build the Athena project against a non-standard CURL (it's a long story...), I had to realise that the current configuration for the CrestApi package is quite broken. (cc. @mmineev) 😦

I had to fix the following things:

  • The only thing that the library publicly depends on is nlohmann_json. Everything else is a private dependency on it.
  • The Boost dependency was set up incorrectly, using imported targets. We don't do that. We use ${Boost_INCLUDE_DIRS} and ${Boost_LIBRARIES} for linking against Boost. Plus, as far as I could see, no Boost library is actually needed for this library. It only uses header-only parts of Boost.
  • The CURL dependency was not set up correctly. (${CURL_INCLUDE_DIRS} was not used.)

Since the current nightly picks up CURL from /usr, this was not seen there. But of course the current setup is not a robust one. 😦

I also changed how the C++ filesystem library would be used. We had a long discussion about this with @stelzer a while ago, so now I updated this package to follow the same formalism that we adopted for TrigConfIO.

Merge request reports