Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 131
    • Merge requests 131
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30624

Analysis Externals Update, master branch (2020.02.25.)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Attila Krasznahorkay requested to merge akraszna/athena:AnalysisExternalsUpdate-master-20200225 into master Feb 25, 2020
  • Overview 6
  • Commits 5
  • Pipelines 2
  • Changes 13

This is a collection of a number of things, primarily aimed at making AnalysisBase build/behave correctly on macOS.

The full list of changes in atlasexternals-2.0.58 wrt. atlasexternals-2.0.57 is (atlasexternals@2.0.57...2.0.58):

  • Made the environment setup scripts work with path names containing spaces;
  • Taught AtlasCMake how to handle the Apple Clang compiler/linker correctly;
  • Suppressed some long-standing warnings with CMake 3.9+ on macOS.

At the same time I made some cleanup in this repository as well:

  • The projects had version number all over the place. I updated them all to the same (22.0.10) version.
  • Removed the usage of <experimental/array> from MuonStationIndex.cxx. Apple's compiler doesn't have that header anymore, and I couldn't see a reason why it should be included anyway.

Finally, to make the installed AnalysisBase release set up a correct runtime environment on macOS (or any other OS that provides Python 3 from the system), I had to set ATLAS_FORCE_PYTHON2=TRUE for the project. For now... We'll have to see later on how to properly enable the building of both Python 2 and 3 versions of AnalysisBase at the same time... 🤔

Pinging @krumnack.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: AnalysisExternalsUpdate-master-20200225