Undo reversion of "Merge branch 'JetDecorators_190729' into 'master'"
This reverts merge request !30491 (merged), thus re-instating the contents of !25234 (merged). The original MR was reverted (temporarily, while we worked out a solution) because it was causing warnings in jet reconstruction. This turned out to be due to the fact that jet modifiers (some of which newly use DecorHandles) were being applied before the jet collection was recorded to the event store. That issue has since been fixed in !30581 (merged), so it should now be safe to put these changes back in.
Merge request reports
Activity
This merge request affects 4 packages:
- Reconstruction/Jet/JetMomentTools
- Reconstruction/Jet/JetRec
- Reconstruction/Jet/JetRecConfig
- Trigger/TrigAlgorithms/TrigHLTJetRec
Adding @goetz as watcher
added JetEtmiss Reconstruction Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash ab1b1376)Athena AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10036]Hi, from the description I understand that's wanted to go in, but I will change the label for a second confirmation. Please change the label back if yes @wbalunas . L1
Edited by Mazuza Ghneimatadded review-user-action-required label and removed review-pending-level-1 label
- Resolved by Mazuza Ghneimat
Yes, I can confirm we're ready for this to go in. I double-checked the log file to make sure the warnings that happened originally are indeed gone.
added review-pending-level-1 label and removed review-user-action-required label
added review-approved label and removed review-pending-level-1 label
mentioned in commit 3c2c02b4
added sweep:ignore label