Skip to content
Snippets Groups Projects

Improve ByteStream handling for DoubleEventSelector

Merged Tadej Novak requested to merge tadej/athena:des-bs into master
All threads resolved!

Improve ByteStream handling for DoubleEventSelector:

  • unify attribute list names to be able to parse them using event loop managers
  • always treat ByteStream as primary input to ensure proper event context generation

/cc @gemmeren @jchapman

Merge request reports

Pipeline #1452366 passed

Pipeline passed for ff896bd9 on tadej:des-bs

Merged by Frank WinklmeierFrank Winklmeier 5 years ago (Mar 3, 2020 12:17pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak resolved all threads

    resolved all threads

  • Changes and CI look all good and the comment from previous L1 review has been answered. Approving.

    Kira (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 9ac82e9f

  • Please register or sign in to reply
    Loading