Skip to content

Revert "Move from perl RegTest to python version"

Rafal Bielski requested to merge rbielski/athena:revert-regtest into master

This reverts commit 59687531.

In my local tests the python version of regtest script looked to be working fine, so I made the change from regtest.pl to regtest.py in the above commit. It turned out the python version didn't really work as intended and it has a dangerous combination of bugs:

  • ignores the --linematch command-line argument
  • if no lines are matched it fails but exits with code 0

which I clearly overlooked.

Because of this, the trigger log comparison in CI was completely skipped since !30540 (merged) was merged on 24/02 morning. I should've spotted this earlier, but unfortunately I didn't.

Some count changes went in unnoticed during the time, and the newJO test got broken and is now giving zero counts. I update the references as part of this MR to bring back the control over trigger changes in CI, but the newJO test will have to be fixed separately (and reference updated back to non-zero counts).

cc @hartj, @jpanduro, @tbold, @smh, @fwinkl

Merge request reports