Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 168
    • Merge requests 168
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !30812

Merged
Created Mar 03, 2020 by Joerg Stelzer@stelzerDeveloper

Fix generic access to empty lists

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 4

When reading json files into boost::ptree a shortcoming of ptree becomes obvious. The standard ptree, which is conceptually a

struct ptree
{
   string data;                          // data associated with the node
   list< pair<string, ptree> > children; // ordered list of named children
};

, cannot distinguish between an empty string entry key -> "" and an empty array entry key -> []. In both cases the internal data string and the children list are empty.

This was noticed and mentioned by @aporeba in MR !30690 (merged). Here I am fixing this issue by removing the exception throwing for this particular case. If getList(key) is called for key -> "", the return value will be and empty vector<TrigConf::DataStructure>

cc: @aporeba , @tamartin

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-checkEmptySequencers