22.0-unit_test-InDetIdentifier

Add unit tests for the SCT_ID only, using the Boost test framework.

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetIdentifier

Adding @goetz ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 3b431943)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10321]

The CI failure in Trigger_MT_required-test is unrelated and can be ignored.

Jenkins please retry a build

This merge request affects 1 package:

• InnerDetector/InDetDetDescr/InDetIdentifier

Adding @goetz ,@sroe as watchers

CI Result SUCCESS (hash 3b431943)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10377]

I only have a small comment about commented out lines in SCT_ID_test.cxx file. Other than that the code looks fine.

Magdalena (L1 shifter)

added review-user-action-required label and removed review-pending-level-1 label

I did not see your comment, can you explain? If you mean these kind of lines: //Identifier::diff_type calc_offset(const Identifier& base,const Identifier& target) const; then these are simply indicating, for each following test, the method in the header file which is being tested.

added review-pending-level-1 label and removed review-user-action-required label

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit bf272ca3

added sweep:ignore label