Skip to content

Fixing SoftKillerWeightTool warnings

Matt LeBlanc requested to merge (removed):mlb/SoftKillerWeightTool into 21.2

Fixing warnings that come when compiling SoftKillerWeightTool, for example ...

[ 92%] Building CXX object athena/Reconstruction/Jet/JetRecTools/CMakeFiles/JetRecToolsLib.dir/Root/SoftKillerWeightTool.cxx.o
/home/mleblanc/substructure/src/athena/Reconstruction/Jet/JetRecTools/Root/SoftKillerWeightTool.cxx: In member function 'double SoftKillerWeightTool::getSoftKillerMinPt(xAOD::IParticleContainer&) const':
/home/mleblanc/substructure/src/athena/Reconstruction/Jet/JetRecTools/Root/SoftKillerWeightTool.cxx:132:34: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
       accept = (tcc->taste()!= 0)*(tcc->pt()>-1.*FLT_MIN);
                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
/home/mleblanc/substructure/src/athena/Reconstruction/Jet/JetRecTools/Root/SoftKillerWeightTool.cxx: In member function 'std::pair<double, double> SoftKillerWeightTool::getSoftKillerMinPtSplit(xAOD::IParticleContainer&) const':
/home/mleblanc/substructure/src/athena/Reconstruction/Jet/JetRecTools/Root/SoftKillerWeightTool.cxx:165:34: warning: '*' in boolean context, suggest '&&' instead [-Wint-in-bool-context]
       accept = (tcc->taste()!= 0)*(tcc->pt()>-1.*FLT_MIN);
                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~

🍻 MLB

Merge request reports