Skip to content

Updates to the RegSelTool implementation including the Muon Spectrometer tables

Mark Sutton requested to merge sutt/athena:grief into master

These include several updates to the RegSelTool implementation with respect to merge request !30981 (merged)

Firstly better memory handling for the RegSelLUTCondData where the payload is now stored using a unique_ptr to better avoid memory leaks.

Additionally there is an new class for the MDT_RegSelCondAlg which uses the new MDT cabling conditions data to create the table for the RegSelTool.

The RegSelToolConfig.py now has an improved private builder function, which is used to provide public builders for the Pixel, SCT, TRT and MDT.

The SCT Cabling conditions data are now used for the EventIDRange for the SCT table, rather than using the pixel cabling.

Some of the old RegSelSvc code has been retained, but commented since we are still developing.

One additional factor regarding the table creation code for the MDT, TGC, RPC and CSC tables and the New Small Wheel MM and sTGC tables: The createTable() methods are essentially a cut and paste of the original code from the *_RegionSelectorTable classes. I did not originally write this code, and don't want to touch it as that would require a great deal of validation beyond the scope of the changes for this merge request. There are a good many places where that code itself could, and perhaps should be improved, but that would be for the Muon developers for a later day.

For this code change we are implementing the framework to provide the full functionality for the new RegSelTool implementation rather than a general cleanup of the existing code.

Edited by Mark Sutton

Merge request reports