Skip to content
Snippets Groups Projects

22.0-extend_interface-InDetIdentifier

Merged Shaun Roe requested to merge sroe/athena:22.0-extend_interface-InDetIdentifier into master

The neighbours of a module are often retrieved together (phi/eta directions) rather than individually, and all the underlying vectors of neighbours are the same size in SCT_ID. Rather than check the vector sizes one-by-one, it makes sense to do this in one operation and check only once then return all the neighbours. Some calls use the default phi-first ordering, others (space point formation) use eta-first ordering, so both orderings have been introduced in the interface. Finally, in SP formationit may be more efficient to return a per-SCT_ID instance array of the function calls rather than create a (per-call) temporary array of the neighbours themselves each time (to be investigated) so a function-returning method was introduced. Test methods were updated to give (rather cursory) tests of the new methods.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading