ViewHelper code tidy

Fixing whitespace and formatting, since this is supposed to be a "helper" class and therefore it's important to keep it readable.

Also removing a bunch of unused code and methods, on the assumption that by now we've stabilised on correct usage patterns and should guide people towards them rather than providing alternatives.

changed the description

added Core Trigger labels

Tagging @tbold

Looks ok to me. Since this is mostly about a propper coding style, maybe could fit better to atlas coding convention. I.e. method/varaible names start from the small letter?

This merge request affects 1 package:

• Control/AthViews

Adding @ssnyder as watcher

added master review-pending-level-1 labels

resolved all threads

added 2 commits

• ab168e5a - Additional tidying. Renaming of methods/arguments with lower case first letter
• dcf7be32 - Update the EVCAs

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Control/AthViews
• Trigger/TrigSteer/ViewAlgs

Adding @tamartin ,@ssnyder as watchers

It all looks good to me. Thanks Ben

CI Result SUCCESS (hash 34a76146)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10796]

CI Result SUCCESS (hash dcf7be32)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10807]

Looks good. L1

added review-approved label and removed review-pending-level-1 label

added 101 commits

• dcf7be32...1c8f021c - 99 commits from branch atlas:master
• f808439e - Merge branch 'master' of https://gitlab.cern.ch/atlas/athena into ViewHelperTidy
• c3703d30 - Renaming for the new alg

Compare with previous version

This merge request affects 2 packages:

• Control/AthViews
• Trigger/TrigSteer/ViewAlgs

Adding @tamartin ,@ssnyder as watchers

added review-pending-level-1 label and removed review-approved label

added review-approved label and removed review-pending-level-1 label