Skip to content

Remove unnecessary histograms and profiles of SCTErrMonTool (ATLASDQ-680). Add protections against nonexistent histgrams (ATLASRECTS-5378)

Susumu Oda requested to merge oda/athena:master-SCTErrMonTool-v2 into master

https://its.cern.ch/jira/browse/ATLASDQ-680

tmp.HIST_ESD_INT:/run_330470/SCT/GENERAL/Conf
TDirectoryFile*		Conf	Conf
 KEY: TProfile	SCTConfDetails;1	Exclusion from the Configuration
 KEY: TProfile	SCTConfOutM;1	Num of Out Modules in All Region
 KEY: TProfile	SCTConfNew;1	Num of Problematic Modules in All Region
 KEY: TProfile	SCT_ByteStreamParseErrorVsLbs;1	Ave. ByteStreamParseError per LB in All Region
 KEY: TProfile	SCT_TimeOutErrorVsLbs;1	Ave. TimeOutError per LB in All Region
 KEY: TProfile	SCT_BCIDErrorVsLbs;1	Ave. BCIDError per LB in All Region
 KEY: TProfile	SCT_LVL1IDErrorVsLbs;1	Ave. LVL1IDError per LB in All Region
 KEY: TProfile	SCT_PreambleErrorVsLbs;1	Ave. PreambleError per LB in All Region
 KEY: TProfile	SCT_FormatterErrorVsLbs;1	Ave. FormatterError per LB in All Region
 KEY: TProfile	SCT_TrailerErrorVsLbs;1	Ave. TrailerError per LB in All Region
 KEY: TProfile	SCT_TrailerOverflowErrorVsLbs;1	Ave. TrailerOverflowError per LB in All Region
 KEY: TProfile	SCT_HeaderTrailerLimitErrorVsLbs;1	Ave. HeaderTrailerLimitError per LB in All Region
 KEY: TProfile	SCT_ABCDErrorVsLbs;1	Ave. ABCDError per LB in All Region
 KEY: TProfile	SCT_RawErrorVsLbs;1	Ave. RawError per LB in All Region
 KEY: TProfile	SCT_MaskedLinkVsLbs;1	Ave. MaskedLink per LB in All Region
 KEY: TProfile	SCT_RODClockErrorVsLbs;1	Ave. RODClockError per LB in All Region
 KEY: TProfile	SCT_TruncatedRODVsLbs;1	Ave. TruncatedROD per LB in All Region
 KEY: TProfile	SCT_ROBFragmentErrorVsLbs;1	Ave. ROBFragmentError per LB in All Region
 KEY: TProfile	SCT_MissingLinkHeaderErrorVsLbs;1	Ave. MissingLinkHeaderError per LB in All Region
 KEY: TProfile	SCT_MaskedRODVsLbs;1	Ave. MaskedROD per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip0VsLbs;1	Ave. ABCDError_Chip0 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip1VsLbs;1	Ave. ABCDError_Chip1 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip2VsLbs;1	Ave. ABCDError_Chip2 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip3VsLbs;1	Ave. ABCDError_Chip3 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip4VsLbs;1	Ave. ABCDError_Chip4 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Chip5VsLbs;1	Ave. ABCDError_Chip5 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Error1VsLbs;1	Ave. ABCDError_Error1 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Error2VsLbs;1	Ave. ABCDError_Error2 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Error4VsLbs;1	Ave. ABCDError_Error4 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip0VsLbs;1	Ave. TempMaskedChip0 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip1VsLbs;1	Ave. TempMaskedChip1 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip2VsLbs;1	Ave. TempMaskedChip2 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip3VsLbs;1	Ave. TempMaskedChip3 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip4VsLbs;1	Ave. TempMaskedChip4 per LB in All Region
 KEY: TProfile	SCT_TempMaskedChip5VsLbs;1	Ave. TempMaskedChip5 per LB in All Region
 KEY: TProfile	SCT_ABCDError_Error7VsLbs;1	Ave. ABCDError_Error7 per LB in All Region
 KEY: TProfile	SCT_ABCDError_InvalidVsLbs;1	Ave. ABCDError_Invalid per LB in All Region
 KEY: TProfile	SCT_RODSimulatedDataVsLbs;1	Ave. RODSimulatedData per LB in All Region
 KEY: TProfile	SCT_LinksWithMaskedLinkALLVsLbs;1	Ave. Num of Links with MaskedLinkALL per LB in All Region
 KEY: TProfile	SCT_LinksWithErrorsVsLbs;1	Ave. Num of Links with Errors per LB in All Region
 KEY: TProfile	SCT_LinksWithBadErrorsVsLbs;1	Ave. Num of Links with BadErrors per LB in All Region
 KEY: TProfile	SCT_LinksWithLinkLevelErrorsVsLbs;1	Ave. Num of Links with LinkLevelErrors per LB in All Region
 KEY: TProfile	SCT_LinksWithRODLevelErrorsVsLbs;1	Ave. Num of Links with RODLevelErrors per LB in All Region
 KEY: TProfile	SCT_LinksWithMaskedChipALLVsLbs;1	Ave. Num of Links with MaskedChipALL per LB in All Region
 KEY: TProfile	FractionOfSCTFlagErrorsPerLB;1	Frac of SCT Flag errors per LB 
 KEY: TH1F	NumberOfSCTFlagErrorsVsLB;1	Num of SCT Flag errors per LB 
 KEY: TH1F	NumberOfEventsVsLB;1	Num of events per LB 
 KEY: TTree	metadata;1	Monitoring Metadata
===================================================================================================
tmp.HIST_ESD_INT:/run_330470/SCT/GENERAL/errors
TDirectoryFile*		errors	errors
 KEY: TTree	metadata;1	Monitoring Metadata
 KEY: TH1I	Masked Links;1	Number of Masked Links for SCT,ECA,B,ECC
===================================================================================================
tmp.HIST_ESD_INT:/run_330470/SCT/DetectorCoverage
TDirectoryFile*		DetectorCoverage	DetectorCoverage
 KEY: TTree	metadata;1	Monitoring Metadata
 KEY: TH2F	SCT_AllRegion;1	Map of All Region
 KEY: TH2F	SCT_MapOfDisabledLinks;1	Map of Disabled Links
 KEY: TH2F	SCT_MapOfLinksWithBadLinkLevelErrors;1	Map of Links with bad LinkLevelErrors
 KEY: TH2F	SCT_MapOfLinksWithBadRODLevelErrors;1	Map of Links with Bad RODLevelErrors
 KEY: TH2F	SCT_MapOfLinksWithBadErrors;1	Map of Links with Bad Errors
 KEY: TH2F	SCT_MapOfLinksWithPSTrip;1	Map of Links Affected by PS Trip
 KEY: TH2F	SCT_MapOfLinksWithAnyProbelm;1	Map of Links with Any Bad Problem
 KEY: TProfile	SCT_CoverageOfEnabledLinksVsLbs;1	Ave. Coverage of Enabled Links per LB
 KEY: TProfile	SCT_CoverageWithNoBadLinkLevelErrorVsLbs;1	Ave. Coverage of Links with No Bad LinkLevelError per LB
 KEY: TProfile	SCT_CoverageWithNoBadRODLevelErrorVsLbs;1	Ave. Coverage of Links with No Bad RODLevelError per LB
 KEY: TProfile	SCT_CoverageWithNoBadErrorVsLbs;1	Ave. Coverage of Links with No Bad Error per LB
 KEY: TProfile	SCT_CoverageWithNoPSTripVsLbs;1	Ave. Coverage of links Not Affected by PS Trip
 KEY: TProfile	SCT_CoverageOfLinksWithNoBadProblemVsLbs;1	Ave. Coverage of Links With No Bad Problem per LB
 KEY: TProfile	SCT_ModulesWithPSTripVsLbs;1	Ave. Num of Modules Affected by PS Trip per LB in All Region

  • I compared the mean and RMS values of the histograms/profiles before and after my changes and found no differences.

  • There are also online only histograms/profiles and the lumiBlock directories, /run_330470/lb_310/SCT/SCTB/errors etc. Those are untouched.

  • Remove unused/unnecessary parts.

  • Use enum as much as possible.

  • Sort definition order.

  • Simplify for loops.

Tag @kkreul and @shhirose

Add protections against nonexistent histograms.

https://its.cern.ch/jira/browse/ATLASRECTS-5378

Edited by Susumu Oda

Merge request reports