Added possibility to activate TRT drift circle uncertainty mu-corrections by toggling a flag

• Adjust configuration to optionally use offline or online luminosity conditions data for mu dependent TRT error scaling
• Added flag to toggle the usage of this conditions data.

added urgent label

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

Will change ID tracks when reconstructing data (excluding cosmics), since TRT drift circle uncertainties are eventually scaled differently. This should also impact MC reconstruction with pileup (untested). In principle I would also expect changes for online reconstruction, but trigger tests seem unchanged.

added Run2-DataReco-output-changed label and removed InnerDetector master review-pending-level-1 labels

added InnerDetector master review-pending-level-1 labels

09:55:23 “Warning: JENKINS DETERMINED THAT THE BUILD JOB FOR MR ID 240251, HASH add15b3e OS CentOS IS ALREADY RUNNING” 09:55:23 “Info: JOB IS RECOGNIZED AS DUPLICATE AND THEREFORE STOPPED” 09:55:23 Build step 'Execute shell' marked build as failure 09:55:23 Finished: FAILURE

I don't quite understand why Jenkins thinks that the job is already running.

added 1 commit

• 7d8142ba - Fix flake8 warnings.

Compare with previous version

Some flake8 fixes, re-trigger jenkins.

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash add15b3e)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11356]

added 2 commits

• ac1d226e - Activate TRT drift circle uncertainty mu-corrections for data, online, mc.
• a415cb0d - Fix flake8 warnings.

Compare with previous version

resolved all threads

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash 7d8142ba)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11363]

CI Result FAILURE (hash a415cb0d)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11373]

Hi @goetz. It would be very useful to have a description of the MR to aid review. Clara (L1)

added 2 commits

• ea31d25e - Activate TRT drift circle uncertainty mu-corrections for data, online, mc.
• 084b3d63 - Fix flake8 warnings.

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash 084b3d63)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11430]

removed urgent label

marked as a Work In Progress

There does not seem to be an easy way to configure the conditions algorithm which creates the luminosity conditions data correctly for both, trigger and offline. The only possibility I see at the moment, is to pass the information through, whether the TRT error scaling tool is needed for online or offline. I have not made the assessment yet how many tools need to pass this information through, but this involves at least the global chi2 fitter and ROT creator (which may not be at the root of the tool chains) i.e. the change is quite a bit broader than anticipated for a feature (mu dependent error scaling) that is going to be removed. The other possibility is to wait until mu is again available in the xAOD::EventInfo, and revert the usage of the luminosity conditions data instead of the mu from the event info object.

This is a WIP, so I'm taking off the review-pending-level-1 label for now.

MLB (L1)

removed review-pending-level-1 label

Hi @goetz, I think it is the configuration of the LuminosityCondAlgDefault which should deal with this internally, I'll have a look if it is just conditions source difference or something more fundamentally different. I guess you can use lumiAlg = LuminosityCondAlgDefault(isOnline=athenaCommonFlags.isOnline) meanwhile cheers Jiri

added 1758 commits

• 084b3d63...7e9fa908 - 1755 commits from branch atlas:master
• 959b48f0 - Activate TRT drift circle uncertainty mu-corrections for data, online, mc.
• e4f5181d - Fix flake8 warnings.
• 2b1ae8df - Introduce flag to toggle mu dependent TRT error scaling on and off.

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Activate TRT drift circle uncertainty mu-corrections for data, online, mc. to Added possibility to activate TRT drift circle uncertainty mu-corrections by toggling a flag

changed the description

removed Run2-DataReco-output-changed label

There is now a flag which toggles the usage of the luminosity conditions data for the mu dependent TRT error scaling. It can be set via preExec e.g. :

from InDetRecExample.InDetJobProperties import InDetFlags;from RecExConfig.RecFlags import rec;InDetFlags.useMuForTRTErrorScaling.set_Value_and_Lock(True if not rec.doRDOTrigger else False)

By default the flag is off, so no changes are introduced wrt. the current version in master.

WARNING: big files (>100K) are found in the changeset

120K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label

Please resolve the threads / discussions, then re-add the review-pending-level-1 label.

MLB (L1)

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

CI Result FAILURE (hash 2b1ae8df)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12748]

Jenkins please retry a build

added review-pending-expert label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

120K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

This merge request affects 1 package:

• InnerDetector/InDetExample/InDetRecExample

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label and removed review-pending-expert label

CI Result SUCCESS (hash 2b1ae8df)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13153]

This looks good now.

MLB (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 418cf39e