Some cosmetic changes to make the master clorser to the HepMC3 enabled branch

Some cosmetic changes to make the master clorser to the HepMC3 enabled branch Mostly cleanup of codes in the /Generators sbdirectory.

This merge request affects 8 packages:

• Generators/BeamHaloGenerator
• Generators/BoostAfterburner
• Generators/CosmicGenerator
• Generators/FlowAfterburner
• Generators/GenAnalysisTools/EventBoost
• Generators/GenAnalysisTools/TruthTools
• Generators/HforTool
• Generators/Hijing_i

added Generators master review-pending-level-1 labels

CI Result SUCCESS (hash 17df42df)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12000]

Hi @lcorpe , could you, please, have a look?

Andrii

This looks fine to me, mainly minor changes in looping and method names.

Maybe worth @ewelina also taking a quick look ?

Fine with me too.

Hi @akraszna , @fwinkl , could you, please, have a look?

Andrii

Hi @akraszna , @fwinkl , could you, please, have a look?

@averbyts what do you want us to look at specifically? I don't see any significant cmake changes here and generators are certainly not our field of expertise. Other than that, this is now up to the review shifter.

Hi @fwinkl , that sounds trivial, but how one can find out who is the shifter today and who can aprove what?

Just be patient ;-) There is quite some backlog. But the shifter will get to this MR eventually...

Hi @averbyts,

I have a few comments related to the usage of auto. Could you have look ?

Thanks.

Xiaozhong (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @xiaozhon , these auto are completely fine, const HepMC::GenParticle* is not a POD type and it will be removed anyway soon. Moreover, one of the most attractive points in future migration to HepMC3 is the ability to write simpler loops. Concernig the pitr -- not everything in one shot.

Andrii

resolved all threads