21.2 build warning fixes
I noticed that there were several compilation warnings in the AthAnalysis build, and this fixes the ones in the CPAnalysisExamples package. Thanks to @jojungge who advised how the call should be adjusted to remove the warning for the deprecated function call. This MR should remove these warnings:
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/CPAnalysisExamples/ToolExamplesAlg.h:36,
from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/src/ToolExamplesAlg.cxx:6:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/Reconstruction/Jet/JetJvtEfficiency/JetJvtEfficiency/IJetJvtEfficiency.h:9:17: note: #pragma message: This header has been moved to the JetAnalysisInterfaces package. Please update your includes to point here.
#pragma message "This header has been moved to the JetAnalysisInterfaces package. Please update your includes to point here."
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/src/ToolExamplesAlg.cxx: In member function 'virtual StatusCode ToolExamplesAlg::execute()':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/src/ToolExamplesAlg.cxx:130:82: warning: 'virtual Root::TAccept CP::IIsolationCloseByCorrectionTool::acceptCorrected(const xAOD::IParticle&, const std::vector<const xAOD::IParticle*>&, int) const' is deprecated: Please use the accepCorrected(const xAOD::IParticle&x, const xAOD::IParticleContainer& closePar, , int topoetconeModel ) instead
However, also this method is quite computationally expensive. You Should consider the getCloseByIsoCorrection() where the isolation cones are corrected on top [-Wdeprecated-declarations]
Root::TAccept acc = m_elCorrectedIsoSelection->acceptCorrected(*el, all_els);
^
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/CPAnalysisExamples/ToolExamplesAlg.h:23,
from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/CPAnalysisExamples/src/ToolExamplesAlg.cxx:6:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/AnalysisCommon/IsolationSelection/IsolationSelection/IIsolationCloseByCorrectionTool.h:37:35: note: declared here
virtual Root::TAccept acceptCorrected(const xAOD::IParticle& x, const std::vector<const xAOD::IParticle*>& closePar, int topoetconeModel = TopoConeCorrectionModel::DirectCaloClusters) const = 0;
^~~~~~~~~~~~~~~