Skip to content

Split PEB and DS definitions to avoid TrigEDMConfig dependency on Menu

Rafal Bielski requested to merge rbielski/athena:menu-edm-circularity into master

This change is to avoid circular dependency because currently TriggerMenuMT imports the recordable helper function from TrigEDMConfig.TriggerEDMRun3 while TriggerEDMRun3 imports EventBuildingInfo from the Menu.

I would argue that the recordable check doesn't have to be done like this and could easily be a post-config consistency check, thus removing the dependency in the other way (removing the Menu->EDM dependency), but apparently people think this dependency is OK, but the EDM->Menu dependency is not OK. Even if I don't fully buy that argument, here's a proper solution to remove this EDM->Menu dependency.

This is a follow-up from the discussion in !31844 (closed)

cc @markowen, @ckaldero, @okuprash, @tbold, @ssnyder

If this is merged, the Menu Expert instructions for adding Data Scouting chains have to be updated.

BTW, DataScoutingInfo is not a perfect name for the new module because it defines also properties of the full HLT result (no Data Scouting), but I wanted to keep the naming consistent with EventBuildingInfo, StreamInfo, etc. and make it easy to find the DS definitions.

Merge request reports