Skip to content
Snippets Groups Projects

add DerivationFrameworkART package

Merged Lukas Alexander Heinrich requested to merge lheinric/athena:add-derivationfwk-art into master

this adds the DerivationFrameworkART package in order to prepare for Derivation testing

@egramsta @elmsheus

this is a straight copy from 21.2

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold
  • Tomasz Bold
  • Since the scripts are generated do they need to be in the repository at all? There is a similar use-case when generating trigger menus. There the menu files are created during compilation. Maybe something to consider. See: https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TriggerCommon/TriggerMenuXML/CMakeLists.txt

  • This is a big diff -- I am bumping it to L2 ...

    MLB (L1)

    • Resolved by James Catmore

      Hi,

      I have another, principal comment. do you really need to have like 300 python files, which basically contains the same code ?

      I do not think this is efficient at all....

      Shoudln't there be one python file, which is called with many different parameters to have a different tests ?

      Best, Pavol [as L2 MR shifter]

  • Hi @pavol I'm concerned with moving derivation framework code to master but not the original author, so I was hesitant to change this code beyond making it work in master.

    @elmsheus @egramsta any comment here?

  • added urgent label

  • Hi,

    this now becomes urgent as until it is working we are unable to do any kind of physics validation for release 22.

    We should really aim only to fix things that are really problematic at this stage.

    James.

  • James Catmore resolved all threads

    resolved all threads

  • O.K., understood. Then approved from shifter point of view, RC should decide if to merge...

    Pavol [as L2 MR shifter]
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading