Skip to content
Snippets Groups Projects

MuonReadoutGeometry: Always optimize MdtReadoutElement.

Merged Scott Snyder requested to merge ssnyder/athena:opt.MuonReadoutGeometry-20200420 into master
All threads resolved!

Code in MdtReadoutElement makes heavy use of eigen and runs orders of magnitude more slowly without optimization. So force this to be optimized even in debug builds. If you need to debug it you might want to change this. Specifying optimization via an attribute on the particular function didn't work, because that still didn't allow inlining.

Merge request reports

Pipeline #1576673 passed

Pipeline passed for 867dd9d5 on ssnyder:opt.MuonReadoutGeometry-20200420

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Apr 22, 2020 8:45am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Scott Snyder added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

    Adding @rosati ,@nkoehler ,@wleight as watchers

  • Author Developer

    That's not actually really right, because we don't want the -DNDEBUG we get from CMAKE_CXX_FLAGS_RELWITHDEBINFO, but i don't see any assertions in this source, so i'll just leave it.

  • :white_check_mark: CI Result SUCCESS (hash 867dd9d5)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12711]

  • Attila Krasznahorkay resolved all threads

    resolved all threads

  • mentioned in commit 15e8105d

  • Frank Winklmeier mentioned in merge request !34156 (merged)

    mentioned in merge request !34156 (merged)

  • Please register or sign in to reply
    Loading