Skip to content
Snippets Groups Projects

enable the thread-safey checker for MdtCalibrationRegionSvc

Merged Ke Li requested to merge keli/athena:MdtCalibSvc into master
All threads resolved!

enable the thread-safey checker for MdtCalibrationRegionSvc and fix a warning caused by non-const s_iID.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Obo L1. Looks good. Just one modernisation suggestion.

  • Hi @keli ,

    any update here ?

    Thanks, Pavol [as L2 MR shifter]

  • Author Developer

    hi @pavol , Sorry for the late reply, I checked the code and don't think we can use the similar way with the example: https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Control/AthenaExamples/AthExHelloWorld/AthExHelloWorld/IHelloTool.h. This one is derived from another class and has no such interface. Best, Ke

  • Nicolas Koehler resolved all threads

    resolved all threads

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibSvc

    Adding @rosati ,@nkoehler ,@wleight as watchers

  • CI Result FAILURE (hash a1bbe293)

    Athena AthSimulation AnalysisBase AthGeneration
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13688]

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • MuonSpectrometer/MuonCalib/MdtCalib/MdtCalibSvc

    Adding @rosati ,@nkoehler ,@wleight as watchers

  • CI Result SUCCESS (hash a1bbe293)

    Athena AthSimulation AnalysisBase AthGeneration
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13728]

  • mentioned in commit 3e436e3f

  • Please register or sign in to reply
    Loading