Skip to content
Snippets Groups Projects

Extended JetCopier

Merged Mikael Chala requested to merge chala/athena:master-my-topic into master
All threads resolved!

I added the DeepCopy function on top of the already existing ShallowCopy. I also added the IO mode to the latter. I rewrote the getAndRecordJets() to deal with the two types of AuxContainers.

Merge request reports

Checking pipeline status.

Merged by Frank WinklmeierFrank Winklmeier 4 years ago (Apr 23, 2020 11:36am UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Apart from my one comment above, I think this looks good!

  • This merge request affects 1 package:

    • Reconstruction/Jet/JetRec

    Adding @goetz as watcher

  • CI Result SUCCESS (hash 331ded4e)

    Athena AthSimulation AnalysisBase AthGeneration
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12697]

  • Please address the outstanding comments.

    Jason (L1)

  • Mikael Chala added 1 commit

    added 1 commit

    • c45f773d - Python properties capitalised.

    Compare with previous version

  • Mikael Chala resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Reconstruction/Jet/JetRec

    Adding @goetz as watcher

  • CI Result FAILURE (hash c45f773d)

    Athena AthSimulation AnalysisBase AthGeneration
    externals
    cmake
    make
    required tests
    optional tests

    Full details available on this CI monitor view
    Athena: number of compilation errors 0, warnings 0
    AthSimulation: number of compilation errors 0, warnings 0
    AnalysisBase: number of compilation errors 0, warnings 0
    AthGeneration: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12775]

  • Discussions have been resolved and the failure is known and unrelated. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 275dac9b

  • Please register or sign in to reply
    Loading