add JetAnalysisInterfaces
Merge request reports
Activity
This merge request affects 1 package:
- PhysicsAnalysis/Interfaces/JetAnalysisInterfaces
Adding @akraszna as watcher
added Analysis JetEtmiss master review-pending-level-1 labels
❎ CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals ⭕ ✅ ✅ ✅ cmake N/A N/A N/A N/A make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A ❗ Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12864]Just to point out for general awareness, JetInterface already exists which has a bunch of dual-use interfaces not entirely unlike these. The IJetSelector one there in particular is nearly identical to the one here.
added review-user-action-required label and removed review-pending-level-1 label
@lheinric - Not necessarily, I just wanted to make sure you were aware of the ones that are already there, if you think it makes more sense to have these ones be separate, then that's fine with me. The only concern I have is that having two distinct interfaces
IJetSelector
andIJetSelectorTool
could potentially lead to confusion, especially sicne the only difference is a return type.removed review-user-action-required label
This merge request affects 1 package:
- PhysicsAnalysis/Interfaces/JetAnalysisInterfaces
Adding @akraszna as watcher
added review-pending-level-1 label
✅ CI Result SUCCESS (hash 9cb31bac)Athena AthSimulation AnalysisBase AthGeneration externals ✅ ✅ ✅ ✅ cmake ✅ ✅ ✅ ✅ make ✅ ✅ ✅ ✅ required tests ✅ ✅ ✅ ✅ optional tests ✅ ✅ ✅ ✅ Full details available on this CI monitor view
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
✅ AnalysisBase: number of compilation errors 0, warnings 0
✅ AthGeneration: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13364]added urgent label
- Resolved by Matt LeBlanc