Make customSeqGetter avaliable outside FlavorTagDiscriminants

Having access to these functions in a few places would be nice. In particular it's useful in user code where we need to reproduce the calculations that go into b-tagging inputs.

added alsoTargeting:21.9 + 1 deleted label

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

added 21.2 Analysis BTagging JetEtmiss review-pending-level-1 labels

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 9816fbd0)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 43589]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 9816fbd0)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12919]

mentioned in merge request atlas-flavor-tagging-tools/training-dataset-dumper!103 (closed)

I just had a couple comments on the formatting of the code to make it more clear/readable. It should be an easy fix, then I think it should be okay to merge. Marking for user action. ~Joe (L2)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 4614e125 - formatting changes

Compare with previous version

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

added review-pending-level-1 label and removed review-user-action-required label

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 4614e125)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 43601]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 4614e125)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13017]

Please resolve the outstanding threads.

Jason (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 253c79a3 - Change year

Compare with previous version

added 1 commit

• 0362581d - Change year

Compare with previous version

added 1 commit

• 3d23cd03 - copyright commit noise

Compare with previous version

resolved all threads

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 0362581d)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13080]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 253c79a3)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 43603]

added review-user-action-required label and removed review-pending-level-1 label

Jenkins please retry a build.

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 3d23cd03)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13081]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 253c79a3)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13079]

@egramsta , @krumnack : Here again the derivation-related error seen also in !32382 (merged), I suspect a file which was being used for the tests was deleted from /eos. This should be fixed but it has nothing to do with this MR.

Shall we approve? Where is the file being used for derivation tests being specified, can we replace it with an existing one?

Thanks, cheers, Giovanni

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 0362581d)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 15
For experts only: Jenkins output [CI-MERGE-REQUEST 43604]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 3d23cd03)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 15
For experts only: Jenkins output [CI-MERGE-REQUEST 43605]

added review-pending-level-1 label and removed review-user-action-required label

I've seen another MR fail like this today, I think it's a transient thing but I do not have more information yet. Hopefully re-running the CI later will fix it, but I wouldn't do it yet.

MLB (L1)

Code is OK. As discussed in a mail thread let's approve and merge since it might take a while before AthDerivation-related issue is fixed. @krumnack please merge

Cheers, Giovanni (AR shifter)