Skip to content
Snippets Groups Projects

22.0 remove iPatRec/xKalman flags from inDetRecExample

Merged 22.0 remove iPatRec/xKalman flags from inDetRecExample
sroe/athena:22.0-configChanges-InDetRecExample into master
Merged Shaun Roe requested to merge sroe/athena:22.0-configChanges-InDetRecExample into master

Although this MR touches many (sometimes obsolete) packages, most of the changes are simply removing references to the iPatRec and xKalman flags. The main change is their deletion in the InDetRecExample packages, from the flags/jobOptions file. Carried out in the context of ATLIDTRKCP-200.q431 and units tests run locally, q221 didn't run even on the unpatched version.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 15 packages:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
    • InnerDetector/InDetCalibAlgs/TRT_CalibAlgs
    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetBeamSpotExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetMonitoring/TRT_Monitoring
    • InnerDetector/InDetRecTools/TRT_TrackHoleSearch
    • InnerDetector/InDetValidation/InDetPerformanceRTT
    • PhysicsAnalysis/D3PDMaker/InDetD3PDMaker
    • Reconstruction/RecExample/RecExCond
    • Tracking/TrkVertexFitter/TrkVertexSeedFinderUtils
    • Trigger/TrigValidation/TrigInDetValidation

    Adding @cgrefe ,@goetz ,@amorley ,@kzoch ,@ibragimo ,@mvozak ,@battagl ,@sroe ,@csuster ,@jpanduro ,@calfayan ,@hartj ,@stsuno ,@sutt ,@nkoehler ,@rbianchi as watchers

  • ATLAS Robot added Analysis DQ Geometry InnerDetector Reconstruction Tracking Trigger master review-pending-level-1 labels

    added Analysis DQ Geometry InnerDetector Reconstruction Tracking Trigger master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash daf40455)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13120]

  • Shaun Roe
    Shaun Roe @sroe ·
    Author Developer

    Problems appear to be related to this change; will try to address them now.

  • Shaun Roe
    Shaun Roe @sroe ·
    Author Developer

    I don't think this one is due to me: RDOtoRDOTrigger 20:11:05 TrigMuSuperEF_SAonly.MuonSystemExtens... 0 ERROR MuonTGRecTools/src/MuonSystemExtensionTool.cxx:34 (StatusCode Muon::MuonSystemExtensionTool::initialize()): code FAILURE: m_caloExtensionTool.retrieve()

  • Shaun Roe added 1 commit

    added 1 commit

    • cc5f0c80 - Remove iPat reference from TrigInDetConfig

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 16 packages:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
    • InnerDetector/InDetCalibAlgs/TRT_CalibAlgs
    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetBeamSpotExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetMonitoring/TRT_Monitoring
    • InnerDetector/InDetRecTools/TRT_TrackHoleSearch
    • InnerDetector/InDetValidation/InDetPerformanceRTT
    • PhysicsAnalysis/D3PDMaker/InDetD3PDMaker
    • Reconstruction/RecExample/RecExCond
    • Tracking/TrkVertexFitter/TrkVertexSeedFinderUtils
    • Trigger/TrigTools/TrigInDetConfig
    • Trigger/TrigValidation/TrigInDetValidation

    Adding @cgrefe ,@goetz ,@amorley ,@kzoch ,@ibragimo ,@mvozak ,@battagl ,@sroe ,@csuster ,@jpanduro ,@calfayan ,@hartj ,@stsuno ,@sutt ,@nkoehler ,@rbianchi as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE

    Athena AthSimulation AnalysisBase AthGeneration
    externals :o: :o: :white_check_mark: :white_check_mark:
    cmake N/A N/A N/A N/A
    make N/A N/A N/A N/A
    required tests N/A N/A N/A N/A
    optional tests N/A N/A N/A N/A

    :exclamation: Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13158]

  • Shaun Roe added 1 commit

    added 1 commit

    • 794d0cd2 - Remove iPatRec/xKalman from InDetTrigRecExample

    Compare with previous version

  • Shaun Roe
    Shaun Roe @sroe ·
    Author Developer

    Fixed remaining failures, q221, q431 and unit tests pass. Now we'll see if the externals build is fixed...

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 17 packages:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
    • InnerDetector/InDetCalibAlgs/TRT_CalibAlgs
    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetBeamSpotExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/TRT_Monitoring
    • InnerDetector/InDetRecTools/TRT_TrackHoleSearch
    • InnerDetector/InDetValidation/InDetPerformanceRTT
    • PhysicsAnalysis/D3PDMaker/InDetD3PDMaker
    • Reconstruction/RecExample/RecExCond
    • Tracking/TrkVertexFitter/TrkVertexSeedFinderUtils
    • Trigger/TrigTools/TrigInDetConfig
    • Trigger/TrigValidation/TrigInDetValidation

    Adding @cgrefe ,@goetz ,@amorley ,@kzoch ,@ibragimo ,@mvozak ,@battagl ,@sroe ,@csuster ,@jpanduro ,@calfayan ,@hartj ,@stsuno ,@sutt ,@nkoehler ,@rbianchi as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 794d0cd2)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13165]

    • Matt LeBlanc
      Matt LeBlanc @mleblanc ·
      Resolved by Peter Berta

      Hi,

      It looks like these changes introduce new errors in the tests: could you please resolve them?

      For example, in the q221Test-test:

      RDOtoRDOTrigger 13:19:07 Traceback (most recent call last):
RDOtoRDOTrigger 13:19:07   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/jobOptions/RecExCond/RecExCommon_flags.py", line 297, in <module>
RDOtoRDOTrigger 13:19:07     InDetFlags.doxKalman=False
RDOtoRDOTrigger 13:19:07   File "/build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/python/AthenaCommon/JobProperties.py", line 507, in __setattr__
RDOtoRDOTrigger 13:19:07     raise AttributeError(errString)
RDOtoRDOTrigger 13:19:07 AttributeError: JobPropertyContainer:: JobProperties.InDetJobProperties does not have property doxKalman
RDOtoRDOTrigger 13:19:07 ERROR: Could not instantiate InDetFlags

      MLB (L1)

  • Matt LeBlanc added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Shaun Roe added 1 commit

    added 1 commit

    • a874805f - remove refernce to xKalman in RecExCond

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 116K in file InnerDetector/InDetExample/InDetRecExample/python/InDetJobProperties.py

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 17 packages:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
    • InnerDetector/InDetCalibAlgs/TRT_CalibAlgs
    • InnerDetector/InDetConfig
    • InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
    • InnerDetector/InDetExample/InDetAlignExample
    • InnerDetector/InDetExample/InDetBeamSpotExample
    • InnerDetector/InDetExample/InDetRecExample
    • InnerDetector/InDetExample/InDetSLHC_Example
    • InnerDetector/InDetExample/InDetTrigRecExample
    • InnerDetector/InDetMonitoring/TRT_Monitoring
    • InnerDetector/InDetRecTools/TRT_TrackHoleSearch
    • InnerDetector/InDetValidation/InDetPerformanceRTT
    • PhysicsAnalysis/D3PDMaker/InDetD3PDMaker
    • Reconstruction/RecExample/RecExCond
    • Tracking/TrkVertexFitter/TrkVertexSeedFinderUtils
    • Trigger/TrigTools/TrigInDetConfig
    • Trigger/TrigValidation/TrigInDetValidation

    Adding @cgrefe ,@goetz ,@amorley ,@kzoch ,@ibragimo ,@mvozak ,@battagl ,@sroe ,@csuster ,@jpanduro ,@calfayan ,@hartj ,@stsuno ,@sutt ,@nkoehler ,@rbianchi as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply