Skip to content
Snippets Groups Projects

A/B Lines containers initialization from test files for NSW

Merged A/B Lines containers initialization from test files for NSW
ckitsaki/athena:NSWAlign into master
Merged Chara Kitsaki requested to merge ckitsaki/athena:NSWAlign into master

As long as there is no database for the NSW alignment, with this MR a test file with format similar to that used for the old Muon Spectrometer technologies can be read and all the information for the ALines and BLines is passed and initialised to the corresponding containers in the MuonDetectorManager. For development/debugging purposes the code is currently called at initialization from MuonDetectorTool since for MC the Alignment sw isn't running. When the database is ready the code will be adapted accordingly.

adding @stavrop, @rosati and @nkoehler

Edited by Chara Kitsaki

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas Koehler
  • Nicolas Koehler
  • Chara Kitsaki added 1 commit

    added 1 commit

    • c8ad4d49 - insert properties for ascii files

    Compare with previous version

  • Nicolas Koehler
  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas Koehler
  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Nicolas Koehler resolved all threads

    resolved all threads

  • Chara Kitsaki unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Chara Kitsaki changed the description

    changed the description

  • Chara Kitsaki marked as a Work In Progress

    marked as a Work In Progress

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added MuonSpectrometer master review-pending-level-1 labels

    added MuonSpectrometer master review-pending-level-1 labels

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • Chara Kitsaki unmarked as a Work In Progress

    unmarked as a Work In Progress

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash f0ee3d7a)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13183]

  • Nicolas Koehler
  • Chara Kitsaki added 1 commit

    added 1 commit

    • e95cc488 - fix member variable declaration

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash d2ef926f)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13182]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 8bf3b576)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :o: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13187]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash e95cc488)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13206]

  • Nicolas Koehler resolved all threads

    resolved all threads

    • Nicolas Koehler
      Nicolas Koehler @nkoehler ·
      Resolved by Stefano Rosati

      Hi @jchapman, @rosati,

      now we are running into the problem that this MR adds the NSWCondUtils to the MuonCondSvc package and includes them in MuonReadoutGeometry. MuonCondSvc however is not part of AthSimulation.

      I let @ckitsaki and @stavrop comment, but I think the NSWCondUtils will never be needed when running simulation? Is this correct? So I think we either have to hide the usage of NSWCondUtils inside MuonReadoutGeometry by compiler flags for AthSimulation or NSWCondUtils needs to go to a separate package which then needs to be included in the packages of AthSimulation.

      What do people think?

      Best, Nico

  • Nicolas Koehler added 111 commits

    added 111 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • Nicolas Koehler resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 05618fee)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :o: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :o: AthSimulation: number of compilation errors 1, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13240]

  • Nicolas Koehler
    Nicolas Koehler @nkoehler ·

    Hi @akraszna, with the check for AthSimulation inside MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/CMakeLists.txt I could build in AthSimulation locally, but somehow the CI does not seem to pick up this check. Am I missing something? Thanks, Nico

  • Attila Krasznahorkay
  • Nicolas Koehler resolved all threads

    resolved all threads

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 4333c866)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13254]

  • Peter Berta added review-user-action-required label

    added review-user-action-required label

  • Chara Kitsaki added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondSvc
    • MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
    • MuonSpectrometer/MuonGeoModel

    Adding @rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot removed review-user-action-required label

    removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 416aabc4)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13297]

  • Xiaozhong Huang resolved all threads

    resolved all threads

  • Xiaozhong Huang
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply