Skip to content

Add additional beamspot tests to validate the ML extensions

Mark Sutton requested to merge sutt/athena:21.3-ml into 21.3

These tests add modified versions of the beamspot tests which run a full scan track reconstruction.

There are two additional jobs, one without the machine learning extensions, and the other including the ML extensions.

The xml files are used to keep the details of the jobs - for historical reasons, since the RTT used xml. The test_*.sh files are autogenerated from the xml files.

The two additional new xml files

TrigInDetValidation_beamspot_ttbar_pu80_fs.xml
TrigInDetValidation_beamspot_ttbar_pu80_fsml.xml

are copies of the original file

TrigInDetValidation_beamspot_ttbar_pu80_zfinder.xml

and as such should not really be reviewed as there are only in fact three lines which are different ...

% diff TrigInDetValidation_beamspot_ttbar_pu80_{zfinder,fs}.xml
1c1
<          <athena trendId='all_pu80' userJobId='TrigInDetValidation_beamspot_ttbar_pu80_zfinder'>
>          <athena trendId='all_pu80' userJobId='TrigInDetValidation_beamspot_ttbar_pu80_fs'>
4c4
< 	    <commandLineFlags>EventMax=1000;fastZFinder=True;rec.doFloatingPointException.set_Value_and_Lock(False)</commandLineFlags>
> 	    <commandLineFlags>EventMax=1000;rec.doFloatingPointException.set_Value_and_Lock(False)</commandLineFlags>
35c35
<                 <argvalue>data-all.root data-beamspot_ttbar_pu80_zfinder-reference.root HLT_beamspot_allTE_trkfast_InDetTrigTrackingxAODCnv_BeamSpot_FTF -d HLTL2-test-plots  </argvalue>
>                 <argvalue>data-all.root data-beamspot_ttbar_pu80_fs-reference.root HLT_beamspot_allTE_trkfast_InDetTrigTrackingxAODCnv_BeamSpot_FTF -d HLTL2-test-plots  </argvalue>

and so on. Similarly the generated test scripts ...

test/test_trigindetvalidation_beamspot_ttbar_pu80_fs.sh
test/test_trigindetvalidation_beamspot_ttbar_pu80_fs.sh

again are autogenerated and so should probably not be reviewed.

However, there are some changes to the generation script to take into account some comments from !32417 (merged)

None of the code here is executed as standard athena - they are scripts to be used for the ID Trigger ART tests, and as such contain no compilable code, and no code that is executed in any of the other CI tests, so should be unaffected by the status of any of the make or required tests.

FIXME: using the original XML files as a source of the details of the job configuration is far from ideal and was done only because the RTT used XML. Now that the RTT is no longer with us, we need at some point, come up with some new way to store the relevant information for the generation, perhaps based on json files or something similar. This would be a longer term project that these changes

Edited by Mark Sutton

Merge request reports