Master fixes for in det config

This contains various fixes for the new configuration e.g.

• Fixes for logic, for GaudiConfig2 etc
• Remove unifySet
• Fix for returning tuple from Cfg functions (deprecated)
• Use CompFactory and migrate to GaudiConfig2 notation

Please treat this as new functionality, which is still incomplete. i.e. there are a few bits of commented out code left, but this will be cleaned up in later MRs. And this this MR means that others can continue the work of getting it complete.

It is still not functional but it at least starts to run now.

Ping @iyeletsk @goetz @sroe @wlampl @mhodgkin

added NewConfig label

changed the description

This merge request affects 2 packages:

• InnerDetector/InDetConditions/SiLorentzAngleTool
• InnerDetector/InDetConfig

Adding @goetz ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result SUCCESS (hash 01676024)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13367]

This looks OK, the CI is clean.

MLB (L1)

added review-approved label and removed review-pending-level-1 label

Hi @emoyse

any reason why TrackReco.py isn't called TrackRecoConfig.py (as most other new-style config files)?

• Walter

Nope. Not my naming. ;-)

I agree it should be changed - I will do so in the next MR (which will be soon).

merged

mentioned in commit c6b1d7f8

added sweep:ignore label