Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 127
    • Merge requests 127
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !32857

JetSubstructureMomentTools simplifying string operations and adding M3

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jason Robert Veatch requested to merge jveatch/athena:21.2-D3 into 21.2 May 13, 2020
  • Overview 37
  • Commits 18
  • Changes 12

This MR implements a change suggested by @krumnack in !29837 (merged). It makes use of structs to significantly reduce the number of string operations in the ECF and N-Subjettiness tools. Some other code cleanup (such as making the comments doxygen compatible) and optimization is also implemented, including no longer calculating ECFG_3_3_2 that is not used in any ECFG ratios. Additionally, the possibility of calculating M3 is included, but turned off by default.

Local tests have validated that the moment calculations are not impacted by these changes. The CPU time gains are small but consistent. It is difficult to quantify the exact gains since they depend significantly on the number of moments and other that are scheduled.

Tagging @sschramm, @delitez, @wbalunas, and @sawyer for comments.

Edited May 20, 2020 by Jason Robert Veatch
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.2-D3