ParametersBase : Avoid a few virtual that did not to be, move inline methods inside the .icc

• Change a few method that can be non-virtual to be so
• Move a few more (almost all) inline methods inside theParameterBase.icc.
• Add a convenient ctor for ParametersBase.
• Also since ParameteBase is abstract , ctors do not need to be public (we can anyhow construct a concete ParameteRBase object only ParameterT ones)

This merge request affects 1 package:

• Tracking/TrkEvent/TrkParametersBase

Adding @amorley as watcher

added JetEtmiss Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 3b8018d4)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14065]

Hmmm compilation/linker failure on AthSimulation ```fake_mutex_unlock`` and ThreadLocal singleton does not seem related ...

MakeFiles/G4HiveEx.dir/src/G4InitTool.cxx.o: In function `G4Cache<G4WorkerThread*>::~G4Cache()':
G4InitTool.cxx:(.text._ZN7G4CacheIP14G4WorkerThreadED2Ev[_ZN7G4CacheIP14G4WorkerThreadED5Ev]+0x2a): undefined reference to `fake_mutex_lock_unlock(int*)'
G4InitTool.cxx:(.text._ZN7G4CacheIP14G4WorkerThreadED2Ev[_ZN7G4CacheIP14G4WorkerThreadED5Ev]+0x84): undefined reference to `fake_mutex_lock_unlock(int*)'
CMakeFiles/G4HiveEx.dir/src/G4InitTool.cxx.o: In function `G
.....
CMakeFiles/G4HiveEx.dir/src/G4InitTool.cxx.o:G4InitTool.cxx:(.text._ZN22G4ThreadLocalSingletonI14G4WorkerThreadEC2Ev[_ZN22G4ThreadLocalSingletonI14G4WorkerThreadEC5Ev]+0x45): more undefined references to `fake_mutex_lock_unlock(int*)' follow
collect2: error: ld returned 1 exit status
error: Failed to execute /build2/ci-builds/master/AthSimulation/build/AthSimulation/CMakeFiles

changed the description

Looks good, scaling to L2 for further review

added review-pending-level-2 label and removed review-pending-level-1 label

Agree, looks fine to me as well, approving.

Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 78c63564

added sweep:ignore label