The main goal of this MR is to get rid of a copy-paste with very long history that is the content of the file jobOfragment_ReadBS_standalone.py. None of the options set there are needed / valid / justified right now. If anything from these lines would be needed, the clients needing it should take care of the correct configuration. Several related changes are made to clean up the configuration and make everything work.
The specific changes and their relations are:
jobOfragment_ReadBS_standalone.py is removed.ByteStreamConfig.py is also removed, making the function TrigBSReadCfg redundant. Since it is used by many clients, it is left as an alias of ByteStreamReadCfg for now. Clients will be adapted in a separate MR and the TrigBSReadCfg will be removed then.ByteStreamReadCfg - the legacy EventInfo BS converter was deleted months ago and this line must've been missed and was causing unnecessary warnings in every job reading BS.runHLT_standalone.py is replaced with new-JO fragment (ByteStreamReadCfg from ByteStreamConfig.py) to keep the Run-3 configuration consistent and up to date. This involved a small move of flags import in runHLT_standalone.py, so cc @stelzer.CAtoGlobalWrapper to also merge AppMgr properties. This also fixes ATR-21307. cc @tbold, @wlampl
jobOfragment_ReadBS_standalone.py, namely TrigMuonRoITool. The way it works relies on non-MT-friendly solution involving Gaudi Converter for MUCTPI_RDO which was hidden in the configuration. I wrote a new configuration fragment for the tool where this dependency is explicit and comments are left explaining what should be done in the future for MT-friendly solution. cc @sshaw, @wiedenma
ByteStreamReadCfg with explicitly naming the required types instead of using the old TrigBSReadCfg
Flagging this as full-unit-tests because of the changes in central parts of configuration.