Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 184
    • Merge requests 184
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !33176

Merged
Created May 26, 2020 by Attila Krasznahorkay@akrasznaMaintainer

xAOD Dictionary Updates, master branch (2020.05.26.)

  • Overview 5
  • Commits 12
  • Pipelines 1
  • Changes 44

After !33004 (merged) and !33096 (merged), this should be the final step in collecting everything from !32081 (closed) into the master branch.

This last step is pretty much the trickiest of the three. It moves dictionaries between libraries, while doing the same sort of updates that the previous 2 were doing. Highlights include:

  • Created the CaloGeoHelpersDict dictionary, to collect dictionaries that were previously split between CaloDetDescrDict, CaloEventDict and xAODCaloRingsDict;
    • At the same time I couldn't help myself, I had to clean up the CMake configuration of CaloDetDescr a bit...;
  • Created the xAODCoreSTLDict dictionary to collect all the "pure STL" dictionaries used by the xAOD EDM;
    • At the same time made some cleanup in the xAODCore package, as some of the naming in it was left over from CMT/RootCore times;
  • Updated the rest of the packages in the same way as in !33004 (merged) and !33096 (merged), moving the "pure STL" dictionaries out from all of them, into xAODCoreSTLDict;
  • Cleaned up a very confusing src/JetTrigAuxContainer_v2.cxx file from xAODJet. I don't even know from what time it was left in that place. 😕
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xAODDictUpdates-master-20200525