Skip to content

GitLab

Fix ITk irreproducibility [ATLITKSW-117]

Merged Thomas Strebler requested to merge tstreble/athena:ATLITKSW-117-fix into 21.9

This MR addresses an irreproducibility issue observed in ATLITKSW-117

A check for invalid SiCellId is added in the phiPitch functions.

The negative value of the pitch at the middle of the sensor is returned to allow for potential error catching while still being usable in cases such as

https://gitlab.cern.ch/atlas/athena/-/blob/21.9/InnerDetector/InDetRecTools/SiClusterOnTrackTool/src/SCT_ClusterOnTrackTool.cxx#L289

where the value is squared.

FYI @ncalace @nstyles @hessey

Edited by Thomas Strebler