MC truth in release 22 version of DAOD_PHYS

This MR makes use of !33167 (merged) and !33139 (merged) and introduces MC truth into DAOD_PHYS in master. Necessarily a number of components have been commented out as they rely on other software that has not been migrated into release 22 and will need to be added in further MRs. The missing components are as follows - if no file name is provided the commented lines are in MCTruthCommon.py.

• Q/G decoration jets (TruthDerivationTools.py)
• TruthMetaDataWriter
• TruthCategories (PHYS.py)
• CopyTruthJetParticles
• addAntiKt4TruthDressedWZJets
• truth_groomed
• scheduleTauTruthTools
• GenFilterTools in GenFilterToolSetup.py
• addTruthEnergyDensity
• TauTruth (PHYS.py)
• LHE3 weights (PHYS.py)
• addTruthJets (PHYS.py) - seg fault if uncommented
• TruthQGDecorationTool
• TauTruth omitted from TruthNavigationDecorator
• addLargeRJetD2 (complains about missing AntiKt10...R20Jets)

added Derivation master labels

This merge request affects 2 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkMCTruth
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys

Adding @zmarshal as watcher

added review-pending-level-1 label

Tagging @zmarshal @lheinric

Thanks James! Just notifying a few people here...

For the LHE3 weights, @lcorpe

For the truth jet building, @wbalunas and @sawyer

For the tau tools, @martindl

Several of the others are probably on me, but some are dependent on the above being fixed :-)

In case you have the energy, this might be a good time to move header files to src, since very few if any need to be public.

Best, Zach

CI Result SUCCESS (hash cec1e70e)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14742]

In general, this looks fine. Can you please confirm if the commented out code all needs to be kept (I saw that it was mentioned in the description, but it would be useful in that case to add an additional comment with these sections in the code indicating why they are kept in and what they are waiting for). Otherwise, if they can be removed to tidy up the code, that would be great. Sending on to L2 for a second check. Clara (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @cnellist ,

indeed, all of the commented code needs to be kept in place. It will be uncommented in the next days as more issues are fixed elsewhere.

Thanks!

James.

resolved all threads

resolved all threads

Changes look fine, approving.

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit 9b9beaea

removed review-approved label

added review-approved label

mentioned in merge request !33286 (merged)

added sweep:ignore label