Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 156
    • Merge requests 156
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !33367

WIP:Copied some changes from the migrated branch

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Andrii Verbytskyi requested to merge HepMC3_changes_to_the_generator_filters into master Jun 02, 2020
  • Overview 2
  • Commits 3
  • Pipelines 1
  • Changes 49

This MR implements part of changes needed to support HepMC3 in the Generator filters. Most of the changes are either mechanical replacement of the GenParticle* to GenParticlePrt or usage of auto for complicated types.

The migration strategy for the GeneratorFilters subpackage has the following cases:

  • In case the codes of the filter don't depend on the exact HepMC version nothing is changed.

  • In case the codes of the filter don't depend on the exact HepMC version after the replacement of GenParticle* with GenParticlePrt, this replacement is done.

  • In case the migration needs a small change ( typically only the loop over particles), the change is done in a way that would allow inserting 1-2 lines of HePMC3 specific code behind the #ifdef guards in the future MR. These are implemented in another branch.

  • In case it is simpler to rewrite the whole algorithm in HepMC3, nothing is done. The actual code is implemented in another MR and will be committed separately.

Edited Jun 03, 2020 by Andrii Verbytskyi
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: HepMC3_changes_to_the_generator_filters