Skip to content

MacOS fixes for AnalysisBase

Nils Erik Krumnack requested to merge krumnack/athena:macos_fixes into master

Hopefully these can be accepted as straightforward fixes. One is just an include statement that was needed, the other is to disable using a gcc compiler feature.

@ssnyder may want to comment on the later. I don't know if he expects this to work as is with clang on MacOS. I do believe the general keyword exists with clang, but it may need to be used differently. The way it was used it would create an error for a duplicate symbol for ConcurrentBitset::Impl::count(). However, from what I can tell disabling this feature shouldn't cause any issue per se.

Also, fixed some missing overrides that clang complained about. And while doing that switched some finalize functions to destructors (finalize is not supported for tools in AnalysisBase).

Also cherry-picked some changes to bind statements from 21.2 to make them C++17 conform.

Also disabled some FLAKE8 tests in AnalysisBase, since FLAKE8 doesn't seem installed there. I opened a JIRA to add FLAKE8 in AnalysisBase and reenable those tests: https://its.cern.ch/jira/browse/ATLASG-1534

Edited by Nils Erik Krumnack

Merge request reports