Fix wrong IBL error IDs and broken service-record histograms in monitoring
This MR fixes a couple bugs in the PixelMonitoring package related to:
- Some erroneous error IDs of IBL (FE-I4), they were shifted by one integer
- IBL service-record monitoring, where the label strings were corrupted and some labels were not set at all due to wrong for-loop ranges
No other packages are affected, this is P1/offline monitoring code.
Merge request reports
Activity
added 21.0 DQ InnerDetector review-pending-level-1 labels
added 1 commit
- 39c05fbd - Fixed service-record loops with wrong upper range limit
CI Result SUCCESS (hash 12eb8168)Athena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthDataQuality: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 44033] CI Result SUCCESS (hash 39c05fbd)Athena AthDataQuality AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 164
AthDataQuality: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST 44036]Dear @kzoch , please add a description for this MR. The MR description should contain:
-
a concise justification why the changes are necessary
-
possible implications/side effects for other parts of the code
-
link(s) to related JIRA tickets if applicable
It seems to me that there are more updates than just "Added missing commas in initialisation of FE-I4 error labels". If that is the case, please, update also the title.
L1 shifter
-
added review-user-action-required label
@pberta, thanks! The description and title are updated.
removed review-user-action-required label
added review-approved label and removed review-pending-level-1 label
mentioned in commit 0c9a39c5
added sweep:done label
added sweep:failed label
added sweep:ignore label and removed sweep:done sweep:failed labels
mentioned in merge request !34123 (merged)
mentioned in commit 9a1d5052