GeneratorObjects: Fix problems with tests.

In HepMcParticleLink::eventIndex(), the second argument to makeIndex() should be the existing position, not a flag. Fixes an assertion failure.

In populateFilteredGenEvent(), don't reference a map iterator after it's been removed from the map.