findVertex : start cleaning up obsolete TrackParticleBase methods

• After a discusson with @kostyuk and @schaffer my understanding is that the TrackParticleBase (Run-I EDM) findVertex methods can be safely removed (we have not been using then in Run-2)...

Here I try to start the process.

The same issue exists in other parts of the vertexing code, and we could prb get rid of quite a bit of Run-I legacy code in these tools.

changed the description

This merge request affects 5 packages:

• InnerDetector/InDetRecTools/InDetConversionFinderTools
• InnerDetector/InDetRecTools/InDetPriVxFinderTool
• InnerDetector/InDetRecTools/InDetRecToolInterfaces
• InnerDetector/InDetRecTools/InDetVKalPriVxFinderTool
• InnerDetector/InDetRecTools/InDetZVTOPVxFinder

Adding @goetz ,@amorley ,@gavrilen ,@sroe as watchers

added Egamma InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 3c089a98)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15389]

added 1 commit

• 45b9ebb5 - remove usage from InDetZVTOPVxFinder, package seems quite obsolete for MT

Compare with previous version

This merge request affects 6 packages:

• InnerDetector/InDetRecAlgs/InDetZVTOP_Alg
• InnerDetector/InDetRecTools/InDetConversionFinderTools
• InnerDetector/InDetRecTools/InDetPriVxFinderTool
• InnerDetector/InDetRecTools/InDetRecToolInterfaces
• InnerDetector/InDetRecTools/InDetVKalPriVxFinderTool
• InnerDetector/InDetRecTools/InDetZVTOPVxFinder

Adding @goetz ,@amorley ,@gavrilen ,@sroe as watchers

CI Result SUCCESS (hash 45b9ebb5)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15395]

The changes look good to me, and CI passes. Approving.

Xiaozhong (L1)

added review-approved label and removed master review-pending-level-1 labels

added master label

merged

mentioned in commit db42f18d

added sweep:ignore label