CaloUtils: Fix cppcheck warnings.

Scott Snyderrequested to merge
ssnyder/athena:cppcheck.CaloUtils-20200623 into master
  • Prefer preincrement rather than postincrement for user iterators.
  • assert with side effects.

Merge request reports