Further optimisations to eflowRec energy subtraction
We can avoid rerunning track-cluster matching in two places:
- The dR<0.15 cluster list is obviously a subset of the dR<0.2 list, so we can extract it by retaining the distance to each cluster.
- In RecoverSplitShowers, we can just pull out the list of clusters in dR<0.2 rather than recomputing it from the list of clusters to consider (where we filter out clusters that have already been fully subtracted). Using an
unordered_set
we can rapidly test the clusters in the cone to see which ones should be used.
Added sorting of the transient cluster collection prior to moment calculation because there seems to be some order-dependence, and we don't want to introduce physics differences from merely reordering the matched clusters.
WRT the previous implementation, running q221
I find differences in 2 events, where the calibrated neutral PFO transverse momenta change by O(10 MeV), in one case resulting in the order of PFOs in the container changing. The EM-scale PFO four-vectors are not affected, hence the jets are identical, and there are changes in the MET at the level of float precision.
Merge request reports
Activity
added JetEtmiss Reconstruction master review-pending-level-1 labels
CI Result SUCCESS (hash fb6e2628)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests N/A N/A N/A Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16113] CI Result FAILURE (hash fb6e2628)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16135]added 1 commit
- 1f4d7dd1 - Protection against case where a track does not have any matched clusters
CI Result SUCCESS (hash 1f4d7dd1)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16214]added review-approved label and removed review-pending-level-1 label
mentioned in commit 0196c8db
added sweep:ignore label
For reference: ATR-21635