Add ATLAS_CHECK_THREAD_SAFETY to InDetLowBetaFinder package.

• Add ATLAS_CHECK_THREAD_SAFETY to InDetLowBetaFinder package to check thread safety.
  • Add ATLAS_NOT_THREAD_SAFE to printTrtToolBetaLiklihoodDebugFile of InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaWrapper.cxx because it uses static variable.
    • This method is not currently used.
  • Add ATLAS_NOT_THREAD_SAFE to TrtToolBetaLiklihood class and TRT_FEbeta_fcn function because these use global and static variables for TMinuit.
  • Add ATLAS_NOT_THREAD_SAFE to LowBetaAlg because this class uses the thread unsafe TrtToolBetaLiklihood class.
  • Although we can add std::(recursive_)mutex guard to protect global variables, it requires some works.
• No result changes are expected.
• Related to https://its.cern.ch/jira/browse/ATLASRECTS-5560

added 1 commit

• 3d3da85b - Update TrtToolsBetaWrapper.cxx

Compare with previous version

changed the description

marked as a Work In Progress

unmarked as a Work In Progress

WARNING: big files (>100K) are found in the changeset

156K in file InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaLiklihood.cxx

This merge request affects 1 package:

• InnerDetector/InDetRecAlgs/InDetLowBetaFinder

Adding @goetz ,@sroe as watchers

added InnerDetector master review-pending-level-1 labels

CI Result SUCCESS (hash 3d3da85b)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16152]

added review-approved label and removed review-pending-level-1 label

added review-pending-expert label

added 1 commit

• 263b72f4 - Remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from TrtToolsBetaLiklihood.h/cxx. Add...

Compare with previous version

changed the description

ATLAS_NO_CHECK_FILE_THREAD_SAFETY is not used now.

WARNING: big files (>100K) are found in the changeset

156K in file InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaLiklihood.cxx

This merge request affects 1 package:

• InnerDetector/InDetRecAlgs/InDetLowBetaFinder

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label and removed review-approved review-pending-expert labels

CI Result SUCCESS (hash 263b72f4)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16254]

changed the description

The changes look fine and there are no CI issues. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

Merge conflict.

added 412 commits

• 263b72f4...28a54648 - 411 commits from branch atlas:master
• 7af97cb7 - Fix conflict

Compare with previous version

WARNING: big files (>100K) are found in the changeset

156K in file InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaLiklihood.cxx

This merge request affects 1 package:

• InnerDetector/InDetRecAlgs/InDetLowBetaFinder

Adding @goetz ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 7af97cb7)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16311]

2020-06-30T183955 CEST TrigValSteering ERROR    RootComp killed on timeout of 300 seconds

time out

Jenkins please retry a build

WARNING: big files (>100K) are found in the changeset

156K in file InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaLiklihood.cxx

This merge request affects 1 package:

• InnerDetector/InDetRecAlgs/InDetLowBetaFinder

Adding @goetz ,@sroe as watchers

CI Result FAILURE (hash 7af97cb7)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16347]

The CI error is a known issue. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 0aaa769a

added sweep:ignore label