Skip to content

Add ATLAS_CHECK_THREAD_SAFETY to InDetLowBetaFinder package.

Susumu Oda requested to merge oda/athena:master-InDetLowBetaFinder into master
  • Add ATLAS_CHECK_THREAD_SAFETY to InDetLowBetaFinder package to check thread safety.
    • Add ATLAS_NOT_THREAD_SAFE to printTrtToolBetaLiklihoodDebugFile of InnerDetector/InDetRecAlgs/InDetLowBetaFinder/src/TrtToolsBetaWrapper.cxx because it uses static variable.
      • This method is not currently used.
    • Add ATLAS_NOT_THREAD_SAFE to TrtToolBetaLiklihood class and TRT_FEbeta_fcn function because these use global and static variables for TMinuit.
    • Add ATLAS_NOT_THREAD_SAFE to LowBetaAlg because this class uses the thread unsafe TrtToolBetaLiklihood class.
    • Although we can add std::(recursive_)mutex guard to protect global variables, it requires some works.
  • No result changes are expected.
  • Related to https://its.cern.ch/jira/browse/ATLASRECTS-5560
Edited by Susumu Oda

Merge request reports