Remove updateAlignment call for Alines in MuonAlignmentCondAlg

Hi,

this MR removes the updateAlignment call for the Alines in on the MuonDetectorManager from the detectorStore in the MuonAlignmentCondAlg. This update call cannot be made in MT on the manager holding the nominal geometry (without alignment). This MR will show that the removal of this call will result in the test_trig_data_v1Dev_build test failing due to a difference in the output. Adding @stavrop and @sshaw

Best, Nico

mentioned in merge request !33725 (merged)

Jenkins please retry a build

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg

Adding @rosati ,@nkoehler ,@wleight as watchers

added MuonSpectrometer master review-pending-level-1 labels

CI Result FAILURE (hash 2f3f6c7d)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16196]

added review-approved label and removed review-pending-level-1 label

Thanks, Nico! I'll try to take a look to see why exactly the trigger counts are changing from this.

(Also, @tadej approved this, but the failing test is a result of these changes, so better not to merge this just yet I think...).

Cheers,

Savanna

Oops. Being too fast.

added review-user-action-required label and removed review-approved label

Hi @nkoehler , What you say is correct. test_trig_data_v1Dev_build.py fails in this MR because the code it runs uses the positions of the RPC/TGC strips (from the nominal MuonDetectorManager) that now are NOT corrected for alignment. It seems that this makes small changes that show up when the results are compared to the ones produced by the HEAD, where the positions of the RPC/TGC (from the nominal MuonDetectorManager) are updated for alignment. This, to my understanding, has nothing to do with 1 vs multi threads.

added 421 commits

• 2f3f6c7d...ec7c7242 - 419 commits from branch atlas:master
• 817fcc27 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into muAlignAlineUp
• 2e55e020 - only call updateAlignment for Aline for doTrigMuonConfig

Compare with previous version

resolved all threads

This merge request affects 3 packages:

• MuonSpectrometer/MuonConditions/MuonCondGeneral/MuonCondAlg
• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonReconstruction/MuonRecExample

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 2e55e020)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16344]

Hi @fwinkl,

are the q431Digest and triggerMC test expected to fail in the nightly? They were both fine for these changes in the previous CI, but now fail.

Thanks, Nico

Hi @nkoehler,

the difference reported in the xAODDigest test is the number of muons in one of the event (3 vs 4). I think you did push a commit since the previous CI run. Could that explain the difference?

Or we have (again) an reprocibility-isses, possibly related to ATLASRECTS-5492?

• Walter

Jenkins please retry a build

Let's try again ...