Skip to content

WIP: Add ATLAS_CHECK_THREAD_SAFETY to TRT_G4Utilities package

Susumu Oda requested to merge oda/athena:master-TRT_G4Utilities into master
  • Add ATLAS_CHECK_THREAD_SAFETY to TRT_G4Utilities package
    • Add ATLAS_THREAD_SAFE to mutable Athena::MsgStreamMember m_msg
    • Stop use of thread unsafe exit function in TRTVisualization.
    • Add ATLAS_NOT_THREAD_SAFE to the following classes.
      • TRTOutputFile : This class needs give non-const reference for output streaming. static TRTOutputFile* m_pOutputFile cannot be static const.
      • TRTUtilities : This class uses thread unsafe TRTOutputFile. static TRTUtilities* s_pUtilities cannot be static const for output streaming.
      • TRTParameters : Non-thread-safe ReadInputFile and GetInteger are used in constructor.
    • Add ATLAS_NOT_THREAD_SAFE to client classes (and their dependent classes including in TRT_G4_SD package) and methods of thread unsafe TRTParameters, TRTUtilities, TRTOutputFile classes.
    • Add ATLAS_NO_CHECK_FILE_THREAD_SAFETY to ut_TRTParametersTest.cxx because this unit test uses thread unsafe TRTParameters and TRTOutputFile classes.
    • Add ATLAS_NO_CHECK_FILE_THREAD_SAFETY to TRTSensitiveDetector_gtest.cxx because this unit test uses thread unsafe TRTSensitiveDetector class.
  • No result changes are expected.
  • Related to https://its.cern.ch/jira/browse/ATLASRECTS-5560
Edited by Susumu Oda

Merge request reports