TrigMonitoring: Package cleanup
Cleanup TrigJetMonitoring, TrigMinBiasMonitoring, TrigBphysMonitoring, TrigBjetMonitoring:
- delete obsolete files
- enable flake8 and fix code
- cleanup cmake configuration
- move private headers to src directory
Merge request reports
Activity
added DQ JetEtmiss Trigger master review-pending-level-1 labels
CI Result FAILURE (hash fe66a5be)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16317]added review-user-action-required label and removed review-pending-level-1 label
It seems that dependencies are not properly defined.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Trigger/TrigMonitoring/TrigMinBiasMonitoring/src/HLTMinBiasMonTool.h:24:10: fatal error: AthenaMonitoring/ManagedMonitorToolBase.h: No such file or directory #include "AthenaMonitoring/ManagedMonitorToolBase.h"
added 107 commits
-
fe66a5be...5a80ab89 - 103 commits from branch
atlas:master
- 03e0cfdc - TrigBjetMonitoring: CMake cleanup and enable flake8
- 40ae6174 - TrigBphysMonitoring: Package cleanup
- 7b620f9f - TrigMinBiasMonitoring: Package cleanup
- fc478430 - TrigJetMonitoring: Package cleanup
Toggle commit list-
fe66a5be...5a80ab89 - 103 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash fc478430)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16391]added review-approved label and removed review-pending-level-1 label
mentioned in commit 3f4d72af
added sweep:ignore label