Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 187
    • Merge requests 187
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !34304

Overlay: Add BCM new-style config + fix data overlay

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Tadej Novak requested to merge tadej/athena:overlay/bcm into master Jun 30, 2020
  • Overview 5
  • Commits 2
  • Pipelines 2
  • Changes 13

This ended-up a bigger MR than expected, but here we go. The goal was to add new-style config for BCM overlay. In the process data overlay for BCM has also been fixed (ATLASSIM-4622).

Some observations:

  • BCM stores multiple BCIDs for data (5 in my tests), one for MC.
  • The order of collections is not deterministic.

Changes:

  • Map the channels to collections as direct loop is not possible.
  • For data: find event BCID from data RDOs and use that one for overlay, do not store the rest if not required.

/cc @janovak @jchapman

Edited Jul 01, 2020 by Tadej Novak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: overlay/bcm