AnalysisTop: Setup only triggers that are needed

With non-DAOD_PHYS trigger tools we could pass triggers for each year and the triggers for irrelevant years (e.g. 2015 triggers for mc16e sample) were simply ignored and not letting events pass. The tools needed for DAOD_PHYS however crash the code when irrelevant, but valid triggers are setup.

Implementing changes so the relevant triggers are identified and only these are passed to the tools to keep the configuration files same when running on DAOD_PHYS.

While working on the changes I identified unused code in two places. I took this opportunity to delete that code.

added 1 commit

• a934e72b - Using proper initial value for m_year

Compare with previous version

added AnalysisTop label

unmarked as a Work In Progress

WARNING: big files (>100K) are found in the changeset

108K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/TopConfiguration/TopConfig.h

168K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

This merge request affects 3 packages:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopConfiguration
• PhysicsAnalysis/TopPhys/xAOD/TopSystematicObjectMaker

Adding @omajersk ,@yili ,@mvanadia ,@tdado as watchers

added 21.2 Analysis review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

108K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/TopConfiguration/TopConfig.h

168K in file PhysicsAnalysis/TopPhys/xAOD/TopConfiguration/Root/TopConfig.cxx

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash a934e72b)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 44325]

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash a934e72b)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 6
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16632]

added review-approved label and removed review-pending-level-1 label

Hi, @krumnack Nils, since this MR has been approved, would you please merge it?

Best, Rui

merged

mentioned in commit 57bec37d

added sweep:ignore label