Skip to content

WIP: Add ATLAS_CHECK_THREAD_SAFETY to PixelGeoModel package.

Susumu Oda requested to merge oda/athena:master-PixelGeoModel-v3 into master
  • Add ATLAS_CHECK_THREAD_SAFETY to PixelGeoModel package.
    • Add Control/CxxUtils to CMakeLists.txt.
    • Add ATLAS_NOT_THREAD_SAFE to PixelDetectorTool::registerCallback because thread unsafe DataHandle template and StoreGateSvc::regFcn method are used.
    • Add ATLAS_NOT_THREAD_SAFE to GeoVPixelFactory class because static member variables are used.
    • Add ATLAS_NOT_THREAD_SAFE to classes that inherit thread unsafe GeoVPixelFactory class.
    • Add ATLAS_NO_CHECK_FILE_THREAD_SAFETY to PixelDetectorDC1DC2.h/cxx because these are legacy codes.
    • Add ATLAS_NOT_THREAD_SAFE to GeoPixelStaveSupport::getPhysVol method and its derived methods because const method returns non-const pointer.
    • Add ATLAS_THREAD_SAFE to mutable Athena::MsgStreamMember m_msg in GeoPixelTMT class.
    • Add ATLAS_NOT_THREAD_SAFE GeoPixelDetailedStaveSupport::Build method because thread unsafe GeoPixelSiCrystal and GeoPixelModule classes are used.
    • Add ATLAS_CTORDTOR_NOT_THREAD_SAFE to GeoPixelDetailedStaveSupport constructor.
    • Add ATLAS_NOT_THREAD_SAFE to OraclePixGeoManager::legacyManager method because const method returns non-const pointer.
    • Add ATLAS_NOT_THREAD_SAFE to OraclePixGeoManager::commonItems method because const method returns non-const pointer.
    • Add ATLAS_NOT_THREAD_SAFE to bcm, blm and serviceBuilderTool methods of PixelGeoModelAthenaComps class because const methods return non-const pointers.
    • Add ATLAS_CTORDTOR_NOT_THREAD_SAFE to PixelDetectorFactorySR1 constructor because thread unsafe GeoVPixelFactory class is used.
    • Add ATLAS_NOT_THREAD_SAFE to PixelDetectorFactorySR1::create method because thread unsafe GeoPixelServices, GeoPixelBarrel, GeoPixelEndCap classes are used.
    • Add ATLAS_CTORDTOR_NOT_THREAD_SAFE to PixelDetectorFactory constructor because thread unsafe GeoVPixelFactory class is used.
    • Add ATLAS_NOT_THREAD_SAFE to PixelDetectorFactory::create method because thread usnafe GeoPixelEnvelope class is used.
    • Add ATLAS_NOT_THREAD_SAFE to PixelDetectorTool::create method because thread unsafe PixelDetectorFactorySR1 and PixelDetectorFactory constructors are used.
  • No result changes are expected.
  • https://its.cern.ch/jira/browse/ATLASRECTS-5560

Merged this MR into MR !34396 (merged). Close this MR.

Edited by Susumu Oda

Merge request reports