Skip to content

Add ATLAS_CHECK_THREAD_SAFETY to PixelCoralClientUtils and PixelCalibAlgs packages

Susumu Oda requested to merge oda/athena:master-PixelCalibAlgs-v2 into master
  • Add ATLAS_CHECK_THREAD_SAFETY to PixelCoralClientUtils package
  • Add ATLAS_NOT_THREAD_SAFE to thread unsafe classes and methods including PixelConditionsData package.
  • const std::string is used instead of const char*.
  • Add ATLAS_CHECK_THREAD_SAFETY to PixelCalibAlgs package.
  • Remove unnecessary static keyword
  • Add ATLAS_NOT_THREAD_SAFE to PixelChargeInterpolationPlot and PixelClusterOnTrackErrorPlot classes because static variables are used.
  • Add ATLAS_NOT_THREAD_SAFE to methods using const_cast.
  • Add ATLAS_NOT_THREAD_SAFE to PixelChargeInterpolationCalibration class because this uses thread unsafe PixelChargeInterpolationPlot class.
  • Add ATLAS_NOT_THREAD_SAFE to OfflineCalibrationLoop class because this uses thread unsafe PixelChargeInterpolationCalibration class.
  • Add ATLAS_NOT_THREAD_SAFE to PixelRIOs class because this uses thread unsafe PixelChargeInterpolationCalibration class.
  • Add ATLAS_NOT_THREAD_SAFE to NoiseMapBuilder::execute method because this uses thread unsafe DataHandle template.
  • Add ATLAS_NOT_THREAD_SAFE to main function of PlotPixelClusterOnTrackErrors.cxx because this uses thread usnafe PixelClusterOnTrackErrorPlot class.
  • Add ATLAS_NOT_THREAD_SAFE to ReadMap and GetID functions in PixelConvert.cxx because these use global variables.
  • Add ATLAS_NOT_THREAD_SAFE to doAll fuction in doPixelOfflineCalibG4.cxx because this uses thread unsafe PixelRIOs class.
  • Add ATLAS_NOT_THREAD_SAFE to main function in doPixelOfflineCalibG4.cxx because this uses thread unsafe doAll function.
  • Add ATLAS_NOT_THREAD_SAFE to functions using global variables in createDeadModuleList.C.
  • Add ATLAS_NOT_THREAD_SAFE to main function of PlotChargeSharingConstants.cxx because this uses thread unsafe PixelChargeInterpolationPlot class.
  • Add ATLAS_NOT_THREAD_SAFE to doAll fuction of doPixelOfflineCalib.cxx because this uses thread unsafe OfflineCalibrationLoop class.
  • Add ATLAS_NOT_THREAD_SAFE to main function of doPixelOfflineCalib.cxx because this uses thread unsafe doAll function.
  • Add ATLAS_NOT_THREAD_SAFE to functions in updateDeadMaps.C because these uses global variable.
  • Add ATLAS_NOT_THREAD_SAFE to fuctions in hackNoiseMapsForStudyCP.C because these use global variable.
  • Add ATLAS_NOT_THREAD_SAFE to fuctions in updateNoiseMaps.C because these use global variable.
  • Add ATLAS_NOT_THREAD_SAFE PixMapDBWriter::finalize and PixMapOverlayWriter::execute because thread unsafe classes are used.
  • No result changes are expected.
  • https://its.cern.ch/jira/browse/ATLASRECTS-5560

Merge request reports