add ATLAS_CHECK_THREAD_SAFETY to TrkVertexWeightCalculators

• Make IVertexWeightCalculator const (i.e methods are const)
• Make the implementations const
• Then add ATLAS_CHECK_THREAD_SAFETY to the implementations.
• Also add the new style logging
• And removed some quite old conventions (parts of these tools seem to be not really have been touched for quite some time)

The NN implementation was not thread safe.

The problematic line was

m_NN = m_networkToHistoTool->fromHistoToTrainedNetwork(m_NNhistos);

Now this is done at the end of initialize ...

Tracking/TrkVertexFitter/TrkVertexFitterInterfaces/TrkVertexFitterInterfaces/IVertexWeightCalculator.h

 /*
-  Copyright (C) 2002-2017 CERN for the benefit of the ATLAS collaboration
+  Copyright (C) 2002-2020 CERN for the benefit of the ATLAS collaboration
 */
 
 ///////////////////////////////////////////////////////////////////
@@ -11,44 +11,48 @@
 
 #include "GaudiKernel/IAlgTool.h"
 
-//xAOD include
-#include "xAODTracking/VertexFwd.h"
-#include "xAODTracking/VertexAuxContainer.h"
+// xAOD include
 #include "xAODTracking/TrackParticleFwd.h"
+#include "xAODTracking/VertexAuxContainer.h"
+#include "xAODTracking/VertexFwd.h"
 
-namespace Trk
-{
-  static const InterfaceID IID_IVertexWeightCalculator("IVertexWeightCalculator", 1, 0);
-
-  /**
-   @class IVertexWeightCalculaculator
-   @brief Interface class for signal vertex selection.
-
-   For more detailed information, take a look at the header file of the actual
-   implementation files.
-
-   ---------------------------------------------------
-   Changes:
+namespace Trk {
+static const InterfaceID IID_IVertexWeightCalculator("IVertexWeightCalculator",
+                                                     1,
+                                                     0);
 
-   David Shope <david.richard.shope@cern.ch> (2016-06-01)
+/**
+ @class IVertexWeightCalculaculator
+ @brief Interface class for signal vertex selection.
 
-     EDM Migration to xAOD - remove method using VxCandidate
+ For more detailed information, take a look at the header file of the actual
+ implementation files.
 
-  */
+ ---------------------------------------------------
+ Changes:
 
-  class IVertexWeightCalculator : virtual public IAlgTool {
+ David Shope <david.richard.shope@cern.ch> (2016-06-01)
+   EDM Migration to xAOD - remove method using VxCandidate
 
-     public:
-       /** Virtual destructor */
-       virtual ~IVertexWeightCalculator(){};
+*/
 
-       /** AlgTool interface methods */
-       static const InterfaceID& interfaceID() { return IID_IVertexWeightCalculator; };
+class IVertexWeightCalculator : virtual public IAlgTool
+{
 
-       /** Interface for @c xAOD::Vertex */
-       virtual double estimateSignalCompatibility(const xAOD::Vertex& vertex) = 0;
+public:
+  /** Virtual destructor */
+  virtual ~IVertexWeightCalculator() = default;
 
+  /** AlgTool interface methods */
+  static const InterfaceID& interfaceID()
+  {
+    return IID_IVertexWeightCalculator;
   };
+
+  /** Interface for @c xAOD::Vertex */
+  virtual double estimateSignalCompatibility(
+    const xAOD::Vertex& vertex) const = 0;
+};
 }
 
 #endif